basil commented on code in PR #201:
URL: https://github.com/apache/maven-release/pull/201#discussion_r1672776630
##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java:
##########
@@ -96,7 +96,7 @@ public abstract class AbstractRewritePomsPhase extends
AbstractReleasePhase impl
* Regular expression pattern matching Maven expressions (i.e. references
to Maven properties).
* The first group selects the property name the expression refers to.
*/
- private static final Pattern EXPRESSION_PATTERN =
Pattern.compile("\\$\\{(.+)\\}");
+ private static final Pattern EXPRESSION_PATTERN =
Pattern.compile("\\$\\{(.+?)\\}");
Review Comment:
> Causes
[MRELEASE-1151](https://issues.apache.org/jira/browse/MRELEASE-1151).
As explained in
https://github.com/apache/maven-release/pull/202#pullrequestreview-2169941878,
https://github.com/apache/maven-release/pull/202 seems to resolves this issue
(with one exception), and I think this PR should not have been released without
also including https://github.com/apache/maven-release/pull/202. I would
recommend that the next release either include
https://github.com/apache/maven-release/pull/202 or revert this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
