[
https://issues.apache.org/jira/browse/MJAVADOC-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865723#comment-17865723
]
ASF GitHub Bot commented on MJAVADOC-791:
-----------------------------------------
michael-o opened a new pull request, #299:
URL: https://github.com/apache/maven-javadoc-plugin/pull/299
…th maven-toolchains-plugin
This closes #299
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MJAVADOC) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MJAVADOC-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A
more thorough check will
be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> maven-javadoc-plugin not working correctly together with
> maven-toolchains-plugin
> --------------------------------------------------------------------------------
>
> Key: MJAVADOC-791
> URL: https://issues.apache.org/jira/browse/MJAVADOC-791
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: javadoc
> Affects Versions: 3.6.3
> Reporter: Hristo Bozhilov
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 3.7.1
>
>
> We are using maven-javadoc-plugin in conjunction with maven-toolchains-plugin
> and we are facing an unpleasant problem.
> We have defined toolchains.xml file containing jdk versions needed for the
> build.
> For our build automation server we are using jenkins Config File Provider
> plug-in to supply this toolchains.xml file to the build via -t command line
> argument e.g:
> {code:java}
> mvn clean deploy -t <path generated by the Config File Provider
> plug-in>.{code}
> We have maven multi-module build and some modules use maven-javadoc-plugin to
> generate javadocs for our API. Sometimes we have API modules that refer API
> classes located in another API module. maven-javadoc-plugin tries to link all
> of these but it fails every time with this error: "[ERROR] No toolchain found
> for type jdk".
> I've looked to the source repository of maven-javadoc-plugin on github and I
> noticed that it forks maven process to build dependent javadocs without
> passing info from toolchains.xml to the forked maven which is needed to run
> the javadoc build. Instead the forked process always expects that
> toolchains.xml is located to ~/.m2/toolchains.xml and this doesn't work on
> jenkins.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
