michael-o commented on code in PR #198:
URL: https://github.com/apache/maven-site-plugin/pull/198#discussion_r1685772440
##########
src/main/java/org/apache/maven/plugins/site/render/AbstractSiteRenderingMojo.java:
##########
@@ -355,7 +354,7 @@ protected Map<String, MavenReport> locateReports(
for (MavenReportExecution mavenReportExecution : reports) {
MavenReport report = mavenReportExecution.getMavenReport();
- String outputName = report.getOutputName();
+ String outputName = report.getOutputPath();
Review Comment:
Here
##########
src/main/java/org/apache/maven/plugins/site/render/AbstractSiteRenderingMojo.java:
##########
@@ -483,7 +482,7 @@ protected Map<String, DocumentRenderer> locateDocuments(
DocumentRenderer docRenderer = new CategorySummaryDocumentRenderer(
subMojoExecution, docRenderingContext, title, desc1,
desc2, i18n, categoryReports, getLog());
- String filename = docRenderer.getOutputName();
+ String filename = docRenderer.getOutputPath();
Review Comment:
Here
##########
src/main/java/org/apache/maven/plugins/site/render/AbstractSiteRenderingMojo.java:
##########
@@ -460,7 +459,7 @@ protected Map<String, DocumentRenderer> locateDocuments(
DocumentRenderer docRenderer = new CategorySummaryDocumentRenderer(
subMojoExecution, docRenderingContext, title, desc1,
desc2, i18n, categoryReports, getLog());
- String filename = docRenderer.getOutputName();
+ String filename = docRenderer.getOutputPath();
Review Comment:
Here
##########
src/main/java/org/apache/maven/plugins/site/render/AbstractSiteRenderingMojo.java:
##########
@@ -533,7 +532,7 @@ private void populateItemRefs(List<MenuItem> items, Locale
locale, Map<String, M
}
if (item.getHref() == null || item.getHref().length() ==
0) {
- item.setHref(report.getOutputName() + ".html");
+ item.setHref(report.getOutputPath() + ".html");
Review Comment:
Here
##########
src/main/java/org/apache/maven/plugins/site/render/CategorySummaryDocumentRenderer.java:
##########
@@ -149,7 +150,7 @@ public void renderDocument(Writer writer, SiteRenderer
siteRenderer, SiteRenderi
for (MavenReport report : categoryReports) {
sink.tableRow();
sink.tableCell();
- sink.link(report.getOutputName() + ".html");
+ sink.link(report.getOutputPath() + ".html");
Review Comment:
Here
##########
src/main/java/org/apache/maven/plugins/site/render/CategorySummaryDocumentRenderer.java:
##########
@@ -177,18 +178,22 @@ public void renderDocument(Writer writer, SiteRenderer
siteRenderer, SiteRenderi
siteRenderer.mergeDocumentIntoSite(writer, sink, siteRenderingContext);
}
+ @Override
public String getOutputName() {
- return docRenderingContext.getOutputName();
+ return docRenderingContext.getOutputPath();
Review Comment:
Here
##########
src/main/java/org/apache/maven/plugins/site/render/AbstractSiteRenderingMojo.java:
##########
@@ -502,7 +501,7 @@ protected Map<String, DocumentRenderer> locateDocuments(
DocumentRenderer docRenderer = new SitemapDocumentRenderer(
subMojoExecution, docRenderingContext, title,
context.getSiteModel(), i18n, getLog());
- String filename = docRenderer.getOutputName();
+ String filename = docRenderer.getOutputPath();
Review Comment:
Here
##########
src/main/java/org/apache/maven/plugins/site/render/ReportDocumentRenderer.java:
##########
@@ -259,7 +259,7 @@ public void renderDocument(Writer writer, SiteRenderer
siteRenderer, SiteRenderi
@Override
public String getOutputName() {
- return docRenderingContext.getOutputName();
+ return docRenderingContext.getOutputPath();
Review Comment:
Here
##########
src/main/java/org/apache/maven/plugins/site/render/SitemapDocumentRenderer.java:
##########
@@ -162,18 +163,22 @@ private static String relativePath(String href) {
return href.startsWith("/") ? "." + href : href;
}
+ @Override
public String getOutputName() {
- return docRenderingContext.getOutputName();
+ return docRenderingContext.getOutputPath();
Review Comment:
Here
##########
src/main/java/org/apache/maven/plugins/site/run/DoxiaFilter.java:
##########
@@ -139,7 +141,7 @@ public void doFilter(ServletRequest servletRequest,
ServletResponse servletRespo
try {
DocumentRenderer docRenderer = documents.get(path);
logDocumentRenderer(path, localeWanted, docRenderer);
- String outputName = docRenderer.getOutputName();
+ String outputName = docRenderer.getOutputPath();
Review Comment:
Here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
