slawekjaranowski commented on code in PR #309:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/309#discussion_r1720807439
##########
src/it/projects/MJAVADOC-498_modulepath/verify.groovy:
##########
@@ -17,5 +17,6 @@
* under the License.
*/
def log = new File( basedir, 'build.log').text
-
-assert log.count( " --module-path" ) == 3
+def count = log.count( " --module-path" )
+// depends on Maven version
+assert count == 2 || count == 3
Review Comment:
We have a `mavenVersion` property defined so we can add something like
```
assert mavenVersion.startWith('4') && count == x ||
mavenVersion.startWith('3') && count == y
```
##########
src/it/projects/MJAVADOC-498_mm_modulepath/invoker.properties:
##########
@@ -16,3 +16,4 @@
# under the License.
invoker.java.version = 9+
+invoker.goals=clean compile javadoc:javadoc
Review Comment:
clean is not necessary - invoker always clear project directory -
https://maven.apache.org/plugins/maven-invoker-plugin/integration-test-mojo.html#cloneClean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
