gnodet commented on code in PR #1679:
URL: https://github.com/apache/maven/pull/1679#discussion_r1728833841
##########
api/maven-api-spi/src/main/java/org/apache/maven/api/spi/PropertyContributor.java:
##########
@@ -33,9 +34,12 @@
@Consumer
public interface PropertyContributor extends SpiService {
/**
- * Invoked just before session is created with a mutable map that carries
collected user properties so far.
+ * Invoked just before session is created.
*
- * @param userProperties The mutable user properties, never {@code null}.
+ * @param systemProperties Immutable map of system properties, never
{@code null}.
+ * @param userProperties Immutable map of user properties, never {@code
null}.
+ * @param topDirectory The path of top directory, never {@code null}.
*/
- void contribute(Map<String, String> userProperties);
+ Map<String, String> contribute(
+ Map<String, String> systemProperties, Map<String, String>
userProperties, Path topDirectory);
Review Comment:
I'd use a `Map<String, String>` for paths, to store all required paths,
similar to
https://github.com/apache/maven/blob/6ac914d6f97517d827f51afa7aaa41e5acdbe023/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java#L620-L626,
as we probably also need the `rootDirectory`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
