cstamas commented on code in PR #1679: URL: https://github.com/apache/maven/pull/1679#discussion_r1728889706
########## api/maven-api-spi/src/main/java/org/apache/maven/api/spi/PropertyContributor.java: ########## @@ -33,9 +34,12 @@ @Consumer public interface PropertyContributor extends SpiService { /** - * Invoked just before session is created with a mutable map that carries collected user properties so far. + * Invoked just before session is created. * - * @param userProperties The mutable user properties, never {@code null}. + * @param systemProperties Immutable map of system properties, never {@code null}. + * @param userProperties Immutable map of user properties, never {@code null}. + * @param topDirectory The path of top directory, never {@code null}. */ - void contribute(Map<String, String> userProperties); + Map<String, String> contribute( + Map<String, String> systemProperties, Map<String, String> userProperties, Path topDirectory); Review Comment: I like type safe things, so added "proto session" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org