[
https://issues.apache.org/jira/browse/MBUILDCACHE-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876895#comment-17876895
]
ASF GitHub Bot commented on MBUILDCACHE-103:
--------------------------------------------
AlexanderAshitkin commented on code in PR #177:
URL:
https://github.com/apache/maven-build-cache-extension/pull/177#discussion_r1732041354
##########
src/main/java/org/apache/maven/buildcache/BuildCacheMojosExecutionStrategy.java:
##########
@@ -228,20 +232,35 @@ private CacheRestorationStatus restoreProject(
// Verify cache consistency for cached mojos
LOGGER.debug("Verify consistency on cached mojos");
Set<MojoExecution> forcedExecutionMojos = new HashSet<>();
+ Set<MojoExecution> reconciliationExecutionMojos = new HashSet<>();
for (MojoExecution cacheCandidate : cachedSegment) {
if (cacheController.isForcedExecution(project,
cacheCandidate)) {
forcedExecutionMojos.add(cacheCandidate);
} else {
+ if (!reconciliationExecutionMojos.isEmpty()) {
Review Comment:
what is this check for?
> Allow incremental restore in case of plugin parameter mismatch
> --------------------------------------------------------------
>
> Key: MBUILDCACHE-103
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-103
> Project: Maven Build Cache Extension
> Issue Type: Improvement
> Reporter: Réda Housni Alaoui
> Priority: Major
> Labels: pull-request-available
>
> Property {{groups}} of {{maven-surefire-plugin}} allows to run a subset of
> tests matching the property value. E.g. {{groups=foo}} will only execute
> tests tagged with 'foo'.
> If I run a build with {{groups=foo}}, and if a cache entry exists for
> {{groups=null}} (i.e. no test filter), I want the cache entry to be reused as
> much as possible and the {{maven-surefire-plugin}} to be run on top of that.
> I think I need to specify that every non null value for groups should be
> considered as a skip value.
> Following this, what I need is the ability to declare a reconcile entry in
> xml config file looking like this:
> {code:xml}
> <cache>
> <executionControl>
> <reconcile>
> <plugins>
> <plugin artifactId="maven-surefire-plugin" goal="test">
> <reconciles>
> <reconcile propertyName="groups" skipValueRegex=".+"/>
> </reconciles>
> </plugin>
> </plugins>
> </reconcile>
> </executionControl>
> </cache>
> {code}
> Could we introduce this {{skipValueRegex}} that would allow to match multiple
> skip values and fix my issue?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
