[ 
https://issues.apache.org/jira/browse/MNG-8192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet closed MNG-8192.
--------------------------------

> DefaultArtifact constructor no longer accepts empty version
> -----------------------------------------------------------
>
>                 Key: MNG-8192
>                 URL: https://issues.apache.org/jira/browse/MNG-8192
>             Project: Maven
>          Issue Type: Bug
>          Components: Artifacts and Repositories
>    Affects Versions: 3.6.3
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>             Fix For: 4.0.0, 4.0.0-beta-4
>
>
> Due to the change introduced in MNG-6705 
> ([https://github.com/apache/maven/commit/53f04f03e3e58c75dcc791d557758357a6ec7983)]
>  an empty version being passed to the constructor of {{DefaultArtifact}}  
> leads to an {{IllegalArgumentException}}
>  
> {code}
> java.lang.IllegalArgumentException: version can neither be null, empty nor 
> blank
>       at org.apache.commons.lang3.Validate.notBlank(Validate.java:454)
>       at 
> org.apache.maven.artifact.ArtifactUtils.notBlank(ArtifactUtils.java:107)
>       at 
> org.apache.maven.artifact.ArtifactUtils.toSnapshotVersion(ArtifactUtils.java:57)
>       at 
> org.apache.maven.artifact.DefaultArtifact.setBaseVersionInternal(DefaultArtifact.java:389)
>       at 
> org.apache.maven.artifact.DefaultArtifact.selectVersion(DefaultArtifact.java:506)
>       at 
> org.apache.maven.artifact.DefaultArtifact.selectVersionFromNewRangeIfAvailable(DefaultArtifact.java:494)
>       at 
> org.apache.maven.artifact.DefaultArtifact.<init>(DefaultArtifact.java:106)
>       at 
> org.apache.maven.artifact.DefaultArtifact.<init>(DefaultArtifact.java:86)
> {code}
> Prior to Maven 3.6.2 this was throwing no exception at all (only null version 
> values were rejected).
>  
> Although throwing an exception for an invalid version is probably fine it 
> should rather be a {{InvalidArtifactRTException}} thrown for other mandatory 
> but empty arguments in 
> https://github.com/apache/maven/blob/c0012c08aaad27473770fc39ab7e39026238c7e1/maven-artifact/src/main/java/org/apache/maven/artifact/DefaultArtifact.java#L165-L184



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to