michael-o commented on code in PR #173:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/173#discussion_r1771965492
##########
doxia-integration-tools/src/test/java/org/apache/maven/doxia/tools/SiteToolTest.java:
##########
@@ -70,46 +66,16 @@
@PlexusTest
public class SiteToolTest {
- @Inject
- private PlexusContainer container;
-
- @Inject
- private ArtifactRepositoryFactory artifactRepositoryFactory;
-
- @Inject
- @Named("default")
- private ArtifactRepositoryLayout defaultArtifactRepositoryLayout;
-
@Inject
private DefaultSiteTool tool;
- /**
- * @return the repo.
- *
- * @throws Exception
- */
- protected ArtifactRepository getLocalRepo() throws Exception {
- String updatePolicyFlag =
ArtifactRepositoryPolicy.UPDATE_POLICY_ALWAYS;
- String checksumPolicyFlag =
ArtifactRepositoryPolicy.CHECKSUM_POLICY_WARN;
- ArtifactRepositoryPolicy snapshotsPolicy =
- new ArtifactRepositoryPolicy(true, updatePolicyFlag,
checksumPolicyFlag);
- ArtifactRepositoryPolicy releasesPolicy =
- new ArtifactRepositoryPolicy(true, updatePolicyFlag,
checksumPolicyFlag);
- return artifactRepositoryFactory.createArtifactRepository(
- "local",
- getTestFile("target/local-repo").toURI().toURL().toString(),
- defaultArtifactRepositoryLayout,
- snapshotsPolicy,
- releasesPolicy);
- }
-
Review Comment:
Why is this block gone?
##########
doxia-site-model/src/main/mdo/site.mdo:
##########
@@ -66,6 +66,15 @@ under the License.
<type>String</type>
<defaultValue>merge</defaultValue>
</field>
+ <field xml.attribute="true">
+ <description><![CDATA[
+ Whether to enforce a parent site descriptor.
+ ]]></description>
+ <name>enforceParentDescriptor</name>
Review Comment:
Instead of `enforce` I'd use the term 'requre`. E.g., `requireParentSite`.
The term `descriptor` is too confusing and too abstract for most.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
