peterdemaeyer commented on code in PR #60:
URL: https://github.com/apache/maven-clean-plugin/pull/60#discussion_r1832410602
##########
src/test/java/org/apache/maven/plugins/clean/CleanerTest.java:
##########
@@ -45,36 +42,22 @@
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertInstanceOf;
import static org.junit.jupiter.api.Assertions.assertThrows;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.Mockito.inOrder;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.never;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
class CleanerTest {
- private boolean warnEnabled;
-
- /**
- * Use a {@code LinkedHashMap} to preserve the order of the logged
warnings.
- */
- private final Map<CharSequence, Throwable> warnings = new
LinkedHashMap<>();
-
- /**
- * Ideally we should use a mocking framework such as Mockito for this, but
alas, this project has no such dependency.
- */
- private final Log log = new SilentLog() {
-
- @Override
- public boolean isWarnEnabled() {
- return warnEnabled;
- }
-
- @Override
- public void warn(CharSequence content, Throwable error) {
- warnings.put(content, error);
- }
- };
+ private final Log log = mock();
@Test
void deleteSucceedsDeeply(@TempDir Path tempDir) throws Exception {
- final Path basedir = createDirectory(tempDir.resolve("target"));
+ final Path basedir =
createDirectory(tempDir.resolve("target")).toRealPath();
Review Comment:
This is an attempt to fix the tests so that they also work on Windows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
