[ 
http://jira.codehaus.org/browse/WAGON-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_106820
 ] 

Brett Porter commented on WAGON-82:
-----------------------------------

ok, I successfully applied this - but I'm not entirely comfortable with it. 
Firstly, I can't get that change into Maven trunk/branch until wagon would be 
released with it's changes.

However, the upshot of the patch is that the webdav wagon ignores the proxy 
that is passed in.

I think it would be better to take the earlier solution provided by Jochen 
where:
a) we fix the wagon manager to pass the correct proxy in (presumably it's 
giving dav instead of http - surely we can figure that out), or otherwise
b) pass in all the proxies and let the wagon decide which to use.

I'll have to take a closer look at this next week - sorry.

> wagon-webdav does not set http-proxy correctly
> ----------------------------------------------
>
>                 Key: WAGON-82
>                 URL: http://jira.codehaus.org/browse/WAGON-82
>             Project: wagon
>          Issue Type: Bug
>          Components: wagon-webdav
>    Affects Versions: 1.0-beta-2
>         Environment: any system
>            Reporter: Marc Wilhelm
>            Assignee: Brett Porter
>            Priority: Blocker
>         Attachments: WAGON-82-maven-artifact-manager.patch, 
> WAGON-82-tested-maven-artifact-manager.patch, WAGON-82-tested-wagon.patch, 
> WAGON-82-wagon.patch, wagon-webdav.patch
>
>
> Webdav connections through a http-proxy are currently not possible.
> The webdav provider opens first a connection to the target system and checks 
> after this, if a proxy should be used.
> To fix this in the method 
> "org.apache.maven.wagon.providers.webdav.WebdavWagon#openConnection()"  the 
> call "webdavResource = new CorrectedWebdavResource( httpURL );" must be 
> changed into "webdavResource = new CorrectedWebdavResource( );" and after 
> configuring the http-proxy the method call 
> "webdavResource.setHttpURL(httpURL);" must be added.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to