sparsick commented on code in PR #646:
URL: https://github.com/apache/maven-site/pull/646#discussion_r1922269940
##########
content/apt/guides/plugin/guide-java-plugin-development.apt.vm:
##########
@@ -447,12 +447,14 @@ public class MyQueryMojo extends AbstractMojo {
[[2]] {{{/shared/maven-plugin-testing-harness/}Maven Plugin Testing
Harness}}: Testing framework for your Mojos.
- [[3]] {{{https://codehaus-plexus.github.io/}Plexus}}: The IoC container
used by Maven.
+ [[3]] {{{https://eclipse.dev/sisu/index.html}Eclipse Sisu}}: The IoC
container used by Maven 3.
- [[4]] {{{https://codehaus-plexus.github.io/plexus-utils/}Plexus Common
Utilities}}: Set of utilities classes useful for Mojo development.
+ [[4]] {{{../../maven-jsr330.html}Maven & JSR 330}}: How to use JSR 330 in
Plugins
- [[5]] {{{http://commons.apache.org/io/}Commons IO}}: Set of utilities
classes useful for file/path handling.
+ [[5]] {{{https://codehaus-plexus.github.io/plexus-utils/}Plexus Common
Utilities}}: Set of utilities classes useful for Mojo development.
- [[6]] {{{../../plugin-developers/common-bugs.html}Common Bugs and
Pitfalls}}: Overview of problematic coding patterns.
+ [[6]] {{{http://commons.apache.org/io/}Commons IO}}: Set of utilities
classes useful for file/path handling.
+
+ [[7]] {{{../../plugin-developers/common-bugs.html}Common Bugs and
Pitfalls}}: Overview of problematic coding patterns.
Review Comment:
Thanks, @elharo, for your feedback.
As I described above, the focus of my PR is about Plexus DI.
Nevertheless, I think we have now two options:
1) I will open a new PR to address your findings, and please let us focus on
the PR topic.
2) I will extend the focus of my PR, but we should define the focus.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
