jeffjensen commented on code in PR #811:
URL: https://github.com/apache/maven-surefire/pull/811#discussion_r1966776941
##########
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java:
##########
@@ -168,7 +167,10 @@ public class VerifyMojo extends AbstractMojo implements
SurefireReportParameters
private volatile PluginConsoleLogger consoleLogger;
- @Inject
+ public VerifyMojo() {
+ this.logger = LoggerFactory.getLogger(getClass());
Review Comment:
Agreed, normally I would do that here too, but to support tests, the
constructor on line 174 accepts an externally instantiated Logger. This
constructor makes the Logger for non-test specified use. I think it is
preferred this way than to make the instance field non-final and have the other
constructor discard the initial instance with the new one. Please let me know
if that's how you'd rather have it tho and I will change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
