Pankraz76 commented on code in PR #2443:
URL: https://github.com/apache/maven/pull/2443#discussion_r2134611946
##########
its/core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java:
##########
@@ -133,21 +133,11 @@ public void run() {
getLog().info("[MAVEN-CORE-IT-LOG] Creating output file " +
outputFile);
- OutputStream out = null;
- try {
- outputFile.getParentFile().mkdirs();
- out = new FileOutputStream(outputFile);
+ outputFile.getParentFile().mkdirs();
+ try (OutputStream out = new FileOutputStream(outputFile)) {
componentProperties.store(out, "MAVEN-CORE-IT-LOG");
} catch (IOException e) {
- throw new MojoExecutionException("Output file could not be
created: " + outputFile, e);
- } finally {
- if (out != null) {
- try {
- out.close();
- } catch (IOException e) {
- // just ignore
- }
- }
+ throw new MojoExecutionException(e);
Review Comment:
> where the file is closed
please do not forget to mention `flush`, as well. Its just as unnecessary to
do so, like all the rest we see here.
Having to `flush` manually is very rare, therefore its just old coding
propagating **feature envy**, facing the `autocloseable` feature.
@gnodet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
