jira-importer commented on issue #225: URL: https://github.com/apache/maven-jar-plugin/issues/225#issuecomment-2956682889
**[Mike Perham](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=mperham)** commented Jochen, please supply patches which are diff'd off the svn source. Your patches are based off of files with weird names (/tmp/MavenArchiver.java.1???) and can't be applied to SVN. Couple other comments: 1) There's a one or two places where your code doesn't match the Maven style. Please correct if possible. 2) Collections.EMPTY_MAP is immutable AFAIK. It's not clear to me if this Map will be mutated. Please replace it with new HashMap() if the contents are mutable. 3) in your third patch, you do "if containsKey remove". It'd rather see "if containsKey return" as it minimizes redundant work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
