[ 
http://jira.codehaus.org/browse/MECLIPSE-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_111528
 ] 

Tony Falabella commented on MECLIPSE-292:
-----------------------------------------

I have the following configuration:
Windows XP
maven 2.0.7 (not sure if the plugin uses it's own or not so this might not be 
needed)
org.maven.ide.eclipse_0.0.11.20070916-2300
org.maven.ide.eclipse.feature_0.0.11.20070916-2300
eclipse 3.3

As of 2007-10-26, this still appears to be an issue.  It is as the other bug 
[http://jira.codehaus.org/browse/MECLIPSE-143] describes.  If you have both 
"Download Artifact Sources" and "Download Artifact JavaDocs" options checked, 
if sources are found for a library it doesn't even look for JavaDocs.

As a test I created a repository that has both the xxx-javadoc.jar and 
xxx-sources.jar.  I've turned DEBUG logging on.  If I have both "Download 
Artifact Sources" and "Download Artifact JavaDocs" options checked I never see 
anything in the log for it attempting to even look for the xxx-javadoc.jar .  
Thus no xxx-javadoc.jar ends up in the localrepos.  It does properly find the 
xxx-sources.jar and that then appears in the localrepos.  If I remove the 
dependency, clear out the localrepos, and only check the "Download Artifact 
JavaDocs" option and try again, I see the following in the log:
{noformat}
10/26/07 9:06:28 AM EDT: [DEBUG] Trying repository tonylocal2
10/26/07 9:06:28 AM EDT: [DEBUG] SHA1 not found, trying MD5 File: C:\Documents 
and 
Settings\af25830\.m2\futures-source-repository2\org\acegisecurity\acegi-security\1.0.3\acegi-security-1.0.3-javadoc.jar.sha1
 does not exist
10/26/07 9:06:28 AM EDT: [WARN] *** CHECKSUM FAILED - Error retrieving checksum 
file for 
org/acegisecurity/acegi-security/1.0.3/acegi-security-1.0.3-javadoc.jar - 
IGNORING
10/26/07 9:06:28 AM EDT: [DEBUG]   Artifact resolved
10/26/07 9:06:28 AM EDT: Scanned javadoc C:/Documents and 
Settings/af25830/.m2/localrepository/org/acegisecurity/acegi-security/1.0.3/acegi-security-1.0.3-javadoc.jar
 0.0
{noformat}
In this case it does properly find the xxx-javadocs.jar and they then appear in 
the localrepos and are properly associated as javadocs with the jar in Eclipse.

I agree though, it should not be an "either-or" in regards to downloading 
source or javadocs.  

> Behaviour for sources and Javadoc attachement for dependencies should be 
> consistent
> -----------------------------------------------------------------------------------
>
>                 Key: MECLIPSE-292
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-292
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Improvement
>          Components: dependency resolution
>    Affects Versions: 2.4
>         Environment: Windows XP, Maven 2.0.6, maven-eclipse-plugin 
> 2.4-20070628.215652-24
>            Reporter: Denis Cabasson
>            Assignee: Brian Fox
>            Priority: Minor
>             Fix For: 2.5
>
>         Attachments: MECLIPSE-292-fixbug.patch, MECLIPSE-292-updated.patch, 
> MECLIPSE-292.patch
>
>   Original Estimate: 2 hours
>  Remaining Estimate: 2 hours
>
> Why couldn't we have a consistent behaviour for javadoc and sources jar 
> attachment?
> Why not adding a downloadJavadoc property, which, when set to true, would 
> download and attach the javadoc to the dependency.
> I don't really see why javadoc should be a fallback if sources are not 
> available.
> Some developpers might prefer to have javadoc linked, some sources linked and 
> some both. Shouldn't the eclipse plugin allow for all the possiblities 
> instead of stating that the preferred option is always to get the sources 
> instead of the Javadoc?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to