[
https://issues.apache.org/jira/browse/MSOURCES-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17959381#comment-17959381
]
Matthias Bünger commented on MSOURCES-14:
-----------------------------------------
This project has moved from Jira to GitHub Issues. This issue was migrated to
[apache/maven-source-plugin#96|https://github.com/apache/maven-source-plugin/issues/96].
> Replace maven-verifier with maven-plugin-testing-harness
> --------------------------------------------------------
>
> Key: MSOURCES-14
> URL: https://issues.apache.org/jira/browse/MSOURCES-14
> Project: Maven Source Plugin (Moved to GitHub Issues)
> Issue Type: Bug
> Affects Versions: 2.0.3
> Reporter: Jochen Wiedmann
> Assignee: Maria Odea B. Ching
> Priority: Major
> Attachments: maven-source-plugin-harness.patch
>
>
> The test suite of the maven-sources-plugin is currently based on the
> maven-verifier. This has the undesirable consequence, that the test uses the
> *installed* version of the maven-sources-plugin, as opposed to the local
> version.
> The attached patch replaces the maven-verifier with the
> maven-plugin-testing-harness, which doesn't suffer from the same problem.
> Additionally, the speed of the test suite is drastically improved.
> For reviewers: When considering the patches quality, keep in mind that the
> actual Mojo classes and the concrete test classes are almost unchanged. (For
> the latter, there is the required addition of a protected method getGoal().)
> For reviewers: Note the following comment in AbstractSourcePluginTestCase:
> * I don't know, why revision 518116 of this class had the parameters
> * "properties" and "expectNoErrors". The following checks
> demonstrate,
> * that the parameters aren't actually used and may safely be removed.
> * This should be done by the patch reviewer.
> I recommend that the reviewer follows my suggestion by applying a refactoring
> method after applying my patch.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
