[
https://issues.apache.org/jira/browse/SCM-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17961679#comment-17961679
]
ASF GitHub Bot commented on SCM-474:
------------------------------------
jira-importer commented on issue #688:
URL: https://github.com/apache/maven-scm/issues/688#issuecomment-2964613291
**[Andrei
Solntsev](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=asolntsev)**
commented
The patch has been attached.
Short changes description:
1. Replaced SimpleDateFormat by ThreadSafeDateFormat
2. Fixed 1 bug in ChangeSet (line 337)
3. Extracted code from ChangeSet#containsFilename to a separate class
FilenameUtils.
4. Created bulk of unit tests
> Make class ChangeSet thread-safe
> --------------------------------
>
> Key: SCM-474
> URL: https://issues.apache.org/jira/browse/SCM-474
> Project: Maven SCM (Moved to GitHub Issues)
> Issue Type: Improvement
> Components: maven-scm-api
> Affects Versions: 1.2, 1.3
> Reporter: Andrei Solntsev
> Assignee: Olivier Lamy
> Priority: Minor
> Fix For: 1.3
>
> Attachments: MNG-474-maven-core.patch
>
>
> Class org.apache.maven.scm.ChangeSet declares a static member of type
> SimpleDateFormat which is not thread-safe.
> If 2 concurrent treads try to use it, it will lead to error.
> Proposed solution is to use class ThreadSafeDateFormat described here:
> http://asolntsev.blogspot.com/2009/05/threadsafedateformat.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
