jira-importer commented on issue #941: URL: https://github.com/apache/maven-scm/issues/941#issuecomment-2964634439
**[Todd Currie](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=tcurrie)** commented This patch should be adjusted to take into account SCM-745. The regular expression should not make use of the greedy wild card match, otherwise the author name can become corrupted depending on the text of the change description. From the attached patch: @@ -36,7 +36,7 @@ public class PerforceFilelogConsumer { private static final String PERFORCE_TIMESTAMP_PATTERN = "yyyy/MM/dd"; - private static final String LINE_PATTERN = "#(\\d+).**on (.**) by (.*)@"; + private static final String LINE_PATTERN = "#(\\d+) change (\\d+) .* on (.**) by (.**)@"; Should be: @@ -36,7 +36,7 @@ public class PerforceFilelogConsumer { private static final String PERFORCE_TIMESTAMP_PATTERN = "yyyy/MM/dd"; - private static final String LINE_PATTERN = "#(\\d+).**on (.**) by (.*)@"; + private static final String LINE_PATTERN = "#(\\d+) change (\\d+) .**? on (.**?) by (.*?)@"; -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
