[
https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17963473#comment-17963473
]
ASF GitHub Bot commented on SCM-869:
------------------------------------
jira-importer commented on issue #1105:
URL: https://github.com/apache/maven-scm/issues/1105#issuecomment-2964646160
**[Michael
Osipov](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=michael-o)**
commented
This change makes now Wagon fail:
```
[INFO] Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14 s
- i
n org.apache.maven.wagon.providers.scm.ScmSvnExeWagonTest
[INFO] Running org.apache.maven.wagon.providers.scm.ScmGitExeWagonTest
[ERROR] Tests run: 14, Failures: 0, Errors: 5, Skipped: 0, Time elapsed:
1.86 s
<<< FAILURE! - in org.apache.maven.wagon.providers.scm.ScmGitExeWagonTest
[ERROR]
testWagonPutDirectoryDeepDestination(org.apache.maven.wagon.providers.sc
m.ScmGitExeWagonTest) Time elapsed: 0.117 s <<< ERROR!
org.apache.maven.wagon.TransferFailedException: Error listing repository: No
suc
h command 'list'.
Caused by: org.apache.maven.scm.NoSuchCommandScmException: No such command
'list
'.
[ERROR]
testWagonGetFileListWhenDirectoryDoesNotExist(org.apache.maven.wagon.pro
viders.scm.ScmGitExeWagonTest) Time elapsed: 0.044 s <<< ERROR!
org.apache.maven.wagon.TransferFailedException: Error getting filelist from
SCM
Caused by: org.apache.maven.scm.NoSuchCommandScmException: No such command
'list
'.
[ERROR]
testWagonPutDirectoryForDot(org.apache.maven.wagon.providers.scm.ScmGitE
xeWagonTest) Time elapsed: 0.091 s <<< ERROR!
org.apache.maven.wagon.TransferFailedException: Error listing repository: No
suc
h command 'list'.
Caused by: org.apache.maven.scm.NoSuchCommandScmException: No such command
'list
'.
[ERROR]
testWagonPutDirectoryWhenDirectoryAlreadyExists(org.apache.maven.wagon.p
roviders.scm.ScmGitExeWagonTest) Time elapsed: 0.075 s <<< ERROR!
org.apache.maven.wagon.TransferFailedException: Error listing repository: No
suc
h command 'list'.
Caused by: org.apache.maven.scm.NoSuchCommandScmException: No such command
'list
'.
[ERROR]
testWagonPutDirectory(org.apache.maven.wagon.providers.scm.ScmGitExeWago
nTest)
Time elapsed: 0.107 s <<< ERROR!
org.apache.maven.wagon.TransferFailedException: Error listing repository: No
suc
h command 'list'.
Caused by: org.apache.maven.scm.NoSuchCommandScmException: No such command
'list
'.
[INFO]
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR]
ScmGitExeWagonTest>WagonTestCase.testWagonGetFileListWhenDirectoryDoes
NotExist:792
» TransferFailed
[ERROR] ScmGitExeWagonTest>WagonTestCase.testWagonPutDirectory:410 »
TransferF
ailed Er...
[ERROR]
ScmGitExeWagonTest>WagonTestCase.testWagonPutDirectoryDeepDestination:
458 »
TransferFailed
[ERROR] ScmGitExeWagonTest>WagonTestCase.testWagonPutDirectoryForDot:565 »
Tra
nsferFailed
[ERROR]
ScmGitExeWagonTest>WagonTestCase.testWagonPutDirectoryWhenDirectoryAlr
eadyExists:513 » TransferFailed
[INFO]
[ERROR] Tests run: 28, Failures: 0, Errors: 5, Skipped: 0
[INFO]
```
Can you take a look at them? I'd like to continue with your Wagon changes
and push a new release.
> gitexe list() implemented incorrectly
> -------------------------------------
>
> Key: SCM-869
> URL: https://issues.apache.org/jira/browse/SCM-869
> Project: Maven SCM (Moved to GitHub Issues)
> Issue Type: Bug
> Components: maven-scm-provider-gitexe
> Affects Versions: 1.9.5, 1.10.0
> Reporter: Ilya Basin
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 1.10.0
>
>
> Taking the Svn implementation as a model, ScmProvider.list() should be
> implemented as follows:
> * The command must directly query the remote repository for files
> * A local working copy is unnecessary and if it doesn't exist, the remote
> repository must not be checked out.
> * fileSet.getBasedir() indicates where to run the scm binary. The
> recommended value is ".".
> * fileSet.getFileList() indicates the files to list
> * repository indicates the repo URL
> Git (among other SCMs) does not support listing remote files, so the command
> should just fail.
> For listing files in a working copy, users should call the
> ScmProvider.status() method instead.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
