Copilot commented on code in PR #837:
URL: https://github.com/apache/maven-wagon/pull/837#discussion_r2617259486
##########
wagon-provider-api/src/test/java/org/apache/maven/wagon/proxy/ProxyInfoUtilsTest.java:
##########
@@ -50,20 +44,21 @@ public void testValidateNonProxyHostsWithUniqueHost() {
proxyInfo.setType("SOCKSv4");
proxyInfo.setNonProxyHosts("*.apache.org");
- assertTrue("maven.apache.org",
ProxyUtils.validateNonProxyHosts(proxyInfo, "maven.apache.org"));
+ assertTrue(ProxyUtils.validateNonProxyHosts(proxyInfo,
"maven.apache.org"), "maven.apache.org");
- assertFalse("www.ibiblio.org",
ProxyUtils.validateNonProxyHosts(proxyInfo, "www.ibiblio.org"));
+ assertFalse(ProxyUtils.validateNonProxyHosts(proxyInfo,
"www.ibiblio.org"), "www.ibiblio.org");
- assertFalse("null", ProxyUtils.validateNonProxyHosts(proxyInfo, null));
+ assertFalse(ProxyUtils.validateNonProxyHosts(proxyInfo, null), "null");
proxyInfo.setNonProxyHosts(null);
- assertFalse("NonProxyHosts = null",
ProxyUtils.validateNonProxyHosts(proxyInfo, "maven.apache.org"));
+ assertFalse(ProxyUtils.validateNonProxyHosts(proxyInfo,
"maven.apache.org"), "NonProxyHosts = null");
proxyInfo.setNonProxyHosts("");
- assertFalse("NonProxyHosts = \"\"",
ProxyUtils.validateNonProxyHosts(proxyInfo, "maven.apache.org"));
+ assertFalse(ProxyUtils.validateNonProxyHosts(proxyInfo,
"maven.apache.org"), "NonProxyHosts = \"\"");
Review Comment:
The assertion parameters are in the wrong order. In JUnit 5, the message
parameter should be the last argument. The correct order is:
assertFalse(actual, message).
##########
wagon-provider-api/src/test/java/org/apache/maven/wagon/proxy/ProxyInfoUtilsTest.java:
##########
@@ -50,20 +44,21 @@ public void testValidateNonProxyHostsWithUniqueHost() {
proxyInfo.setType("SOCKSv4");
proxyInfo.setNonProxyHosts("*.apache.org");
- assertTrue("maven.apache.org",
ProxyUtils.validateNonProxyHosts(proxyInfo, "maven.apache.org"));
+ assertTrue(ProxyUtils.validateNonProxyHosts(proxyInfo,
"maven.apache.org"), "maven.apache.org");
- assertFalse("www.ibiblio.org",
ProxyUtils.validateNonProxyHosts(proxyInfo, "www.ibiblio.org"));
+ assertFalse(ProxyUtils.validateNonProxyHosts(proxyInfo,
"www.ibiblio.org"), "www.ibiblio.org");
- assertFalse("null", ProxyUtils.validateNonProxyHosts(proxyInfo, null));
+ assertFalse(ProxyUtils.validateNonProxyHosts(proxyInfo, null), "null");
Review Comment:
The assertion parameters are in the wrong order. In JUnit 5, the message
parameter should be the last argument. The correct order is:
assertFalse(actual, message).
##########
wagon-provider-api/src/test/java/org/apache/maven/wagon/proxy/ProxyInfoUtilsTest.java:
##########
@@ -50,20 +44,21 @@ public void testValidateNonProxyHostsWithUniqueHost() {
proxyInfo.setType("SOCKSv4");
proxyInfo.setNonProxyHosts("*.apache.org");
- assertTrue("maven.apache.org",
ProxyUtils.validateNonProxyHosts(proxyInfo, "maven.apache.org"));
+ assertTrue(ProxyUtils.validateNonProxyHosts(proxyInfo,
"maven.apache.org"), "maven.apache.org");
- assertFalse("www.ibiblio.org",
ProxyUtils.validateNonProxyHosts(proxyInfo, "www.ibiblio.org"));
+ assertFalse(ProxyUtils.validateNonProxyHosts(proxyInfo,
"www.ibiblio.org"), "www.ibiblio.org");
- assertFalse("null", ProxyUtils.validateNonProxyHosts(proxyInfo, null));
+ assertFalse(ProxyUtils.validateNonProxyHosts(proxyInfo, null), "null");
proxyInfo.setNonProxyHosts(null);
- assertFalse("NonProxyHosts = null",
ProxyUtils.validateNonProxyHosts(proxyInfo, "maven.apache.org"));
+ assertFalse(ProxyUtils.validateNonProxyHosts(proxyInfo,
"maven.apache.org"), "NonProxyHosts = null");
Review Comment:
The assertion parameters are in the wrong order. In JUnit 5, the message
parameter should be the last argument. The correct order is:
assertFalse(actual, message).
##########
wagon-provider-api/src/test/java/org/apache/maven/wagon/events/SessionEventTest.java:
##########
@@ -111,9 +106,9 @@ public void testConstantValueConflict() {
for (int i = 0; i < values.length; i++) {
for (int j = i + 1; j < values.length; j++) {
+ String msg = "Value confict at [i,j]=[" + i + "," + j + "]";
Review Comment:
Typo in the variable name and message: "confict" should be "conflict".
##########
wagon-provider-api/src/test/java/org/apache/maven/wagon/proxy/ProxyInfoUtilsTest.java:
##########
@@ -50,20 +44,21 @@ public void testValidateNonProxyHostsWithUniqueHost() {
proxyInfo.setType("SOCKSv4");
proxyInfo.setNonProxyHosts("*.apache.org");
- assertTrue("maven.apache.org",
ProxyUtils.validateNonProxyHosts(proxyInfo, "maven.apache.org"));
+ assertTrue(ProxyUtils.validateNonProxyHosts(proxyInfo,
"maven.apache.org"), "maven.apache.org");
- assertFalse("www.ibiblio.org",
ProxyUtils.validateNonProxyHosts(proxyInfo, "www.ibiblio.org"));
+ assertFalse(ProxyUtils.validateNonProxyHosts(proxyInfo,
"www.ibiblio.org"), "www.ibiblio.org");
Review Comment:
The assertion parameters are in the wrong order. In JUnit 5, the message
parameter should be the last argument. The correct order is:
assertFalse(actual, message).
##########
wagon-provider-api/src/test/java/org/apache/maven/wagon/proxy/ProxyInfoUtilsTest.java:
##########
@@ -73,9 +68,9 @@ public void testValidateNonProxyHostsWithMultipleHost() {
proxyInfo.setType("SOCKSv4");
proxyInfo.setNonProxyHosts("*.apache.org|*.codehaus.org");
- assertTrue("maven.apache.org",
ProxyUtils.validateNonProxyHosts(proxyInfo, "maven.apache.org"));
- assertTrue("wiki.codehaus.org",
ProxyUtils.validateNonProxyHosts(proxyInfo, "wiki.codehaus.org"));
+ assertTrue(ProxyUtils.validateNonProxyHosts(proxyInfo,
"maven.apache.org"), "maven.apache.org");
+ assertTrue(ProxyUtils.validateNonProxyHosts(proxyInfo,
"wiki.codehaus.org"), "wiki.codehaus.org");
- assertFalse("www.ibiblio.org",
ProxyUtils.validateNonProxyHosts(proxyInfo, "www.ibiblio.org"));
+ assertFalse(ProxyUtils.validateNonProxyHosts(proxyInfo,
"www.ibiblio.org"), "www.ibiblio.org");
Review Comment:
The assertion parameters are in the wrong order. In JUnit 5, the message
parameter should be the last argument. The correct order is:
assertFalse(actual, message).
##########
wagon-provider-api/src/test/java/org/apache/maven/wagon/proxy/ProxyInfoUtilsTest.java:
##########
@@ -73,9 +68,9 @@ public void testValidateNonProxyHostsWithMultipleHost() {
proxyInfo.setType("SOCKSv4");
proxyInfo.setNonProxyHosts("*.apache.org|*.codehaus.org");
- assertTrue("maven.apache.org",
ProxyUtils.validateNonProxyHosts(proxyInfo, "maven.apache.org"));
- assertTrue("wiki.codehaus.org",
ProxyUtils.validateNonProxyHosts(proxyInfo, "wiki.codehaus.org"));
+ assertTrue(ProxyUtils.validateNonProxyHosts(proxyInfo,
"maven.apache.org"), "maven.apache.org");
+ assertTrue(ProxyUtils.validateNonProxyHosts(proxyInfo,
"wiki.codehaus.org"), "wiki.codehaus.org");
Review Comment:
The assertion parameters are in the wrong order. In JUnit 5, the message
parameter should be the last argument. The correct order is: assertTrue(actual,
message).
##########
wagon-provider-api/src/test/java/org/apache/maven/wagon/proxy/ProxyInfoUtilsTest.java:
##########
@@ -50,20 +44,21 @@ public void testValidateNonProxyHostsWithUniqueHost() {
proxyInfo.setType("SOCKSv4");
proxyInfo.setNonProxyHosts("*.apache.org");
- assertTrue("maven.apache.org",
ProxyUtils.validateNonProxyHosts(proxyInfo, "maven.apache.org"));
+ assertTrue(ProxyUtils.validateNonProxyHosts(proxyInfo,
"maven.apache.org"), "maven.apache.org");
Review Comment:
The assertion parameters are in the wrong order. In JUnit 5, the message
parameter should be the last argument. The correct order is: assertTrue(actual,
message). Currently, this passes the message as the first parameter which will
be interpreted as the boolean value to test.
##########
wagon-provider-api/src/test/java/org/apache/maven/wagon/events/TransferEventTest.java:
##########
@@ -141,10 +111,9 @@ public void testConstantValueConflict() {
for (int i = 0; i < values.length; i++) {
for (int j = i + 1; j < values.length; j++) {
+ String msg = "Value confict at [i,j]=[" + i + "," + j + "]";
Review Comment:
Typo in the variable name and message: "confict" should be "conflict".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
