elharo commented on code in PR #11576:
URL: https://github.com/apache/maven/pull/11576#discussion_r2687638690
##########
api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java:
##########
@@ -186,76 +224,114 @@ public interface XmlNode {
Object inputLocation();
// Deprecated methods that delegate to new ones
+ /**
Review Comment:
I consider these deprecation mistaken and unnecessary, and would prefer to
revert them all before release. The original method names were just fine
##########
api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java:
##########
@@ -61,41 +61,76 @@ public interface XmlNode {
@Deprecated(since = "4.0.0", forRemoval = true)
String CHILDREN_COMBINATION_MODE_ATTRIBUTE =
XmlService.CHILDREN_COMBINATION_MODE_ATTRIBUTE;
+ /**
+ * @deprecated since 4.0.0.
Review Comment:
I don't know if we need to say "since 4.0.0." Will the annotation add this?
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSourceRoot.java:
##########
Review Comment:
This is an unrelated change that should not be in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
