kwin opened a new issue, #1751:
URL: https://github.com/apache/maven-resolver/issues/1751

   ### New feature, improvement proposal
   
   Currently a PUT tasks either receives the artifact as [byte 
array](https://github.com/apache/maven-resolver/blob/2340c676f3aaf920ea7bbb5120b0ade4829a737c/maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/transport/PutTask.java#L135)
 or as 
[Path](https://github.com/apache/maven-resolver/blob/2340c676f3aaf920ea7bbb5120b0ade4829a737c/maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/transport/PutTask.java#L123)
 but exposes it for both only as 
[InputStream](https://github.com/apache/maven-resolver/blob/2340c676f3aaf920ea7bbb5120b0ade4829a737c/maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/transport/PutTask.java#L58).
 Although there is an individual method to get the 
[Path](https://github.com/apache/maven-resolver/blob/2340c676f3aaf920ea7bbb5120b0ade4829a737c/maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/transport/PutTask.java#L58)
 there is none which exposes the byte array.
   
   In order to implement retries without being forced to copy to a temp file 
(like in 
https://github.com/apache/maven-resolver/blob/2340c676f3aaf920ea7bbb5120b0ade4829a737c/maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk11/src/main/java/org/eclipse/aether/transport/jdk/JdkTransporter.java#L439)
 it is important to expose an object which can be seeked to beginning. It would 
make sense to expose `SeekableByteChannel newSeekableByteChannel()` which would 
work equally well on top of both byte array and path.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to