slawekjaranowski commented on code in PR #1574:
URL:
https://github.com/apache/maven-dependency-plugin/pull/1574#discussion_r2701007408
##########
src/test/java/org/apache/maven/plugins/dependency/fromConfiguration/TestUnpackMojo.java:
##########
@@ -107,22 +101,22 @@ public void testGetArtifactItems() throws Exception {
mojo.setArtifactItems(list);
- ArtifactItem result = getSingleArtifactItem(false);
+ ArtifactItem result = getSingleArtifactItem(mojo);
assertEquals(mojo.getOutputDirectory(), result.getOutputDirectory());
File output = new File(mojo.getOutputDirectory(), "override");
item.setOutputDirectory(output);
- result = getSingleArtifactItem(false);
+ result = getSingleArtifactItem(mojo);
assertEquals(output, result.getOutputDirectory());
}
- public void assertMarkerFiles(Collection<ArtifactItem> items, boolean
exist) {
+ private void assertMarkerFiles(UnpackMojo mojo, Collection<ArtifactItem>
items, boolean exist) {
Review Comment:
I will leave it as is, that is a simple method, is more readable to have it
in test class instead of creating utils for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
