desruisseaux commented on code in PR #11702:
URL: https://github.com/apache/maven/pull/11702#discussion_r2812201373
##########
impl/maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java:
##########
@@ -692,49 +692,102 @@ private void initProject(MavenProject project,
ModelBuilderResult result) {
}
/*
- * `sourceDirectory`, `testSourceDirectory` and
`scriptSourceDirectory`
- * are ignored if the POM file contains at least one enabled
<source> element
- * for the corresponding scope and language. This rule exists
because
- * Maven provides default values for those elements which may
conflict
- * with user's configuration.
+ * Source directory handling depends on project type and
<sources> configuration:
*
- * Additionally, for modular projects, legacy directories are
unconditionally
- * ignored because it is not clear how to dispatch their
content between
- * different modules. A warning is emitted if these properties
are explicitly set.
+ * 1. CLASSIC projects (no <sources>):
+ * - All legacy directories are used
+ *
+ * 2. MODULAR projects (have <module> in <sources>):
+ * - ALL legacy directories are rejected (can't dispatch
between modules)
+ * - Physical presence of default directories
(src/main/java) also triggers ERROR
+ *
+ * 3. NON-MODULAR projects with <sources>:
+ * - Explicit legacy directories (differ from default) are
always rejected
Review Comment:
If by current behaviour we mean Maven 3 behaviour, the current behaviour is
to take the source directories from the following elements:
`<sourceDirectory>`, `<scriptSourceDirectory>`, `<testSourceDirectory>`,
`<resources>`, `<testResources>`. This is what we mean by "legacy directories".
The `<source>` element did not existed in Maven 3.
The new `<source>` element provides an unified handling capable to replace
all the legacy elements, and more. But we think that if a developer mixes the
legacy elements with the new `<source>` element, while it would be technically
possible to merge the legacy elements with the `<source>` elements, such mix is
more likely to be a configuration error. This is what this item tries to catch.
For projects that do not use the new `<source>` at all, nothing changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
