ursaj commented on code in PR #760:
URL:
https://github.com/apache/maven-shade-plugin/pull/760#discussion_r2905028108
##########
src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java:
##########
@@ -34,7 +34,7 @@ public class SimpleRelocator implements Relocator {
/**
* Match dot, slash or space at end of string
*/
- private static final Pattern RX_ENDS_WITH_DOT_SLASH_SPACE =
Pattern.compile("[./ ]$");
+ private static final Pattern RX_ENDS_WITH_DOT_SLASH_SPACE =
Pattern.compile("(\\.|/|[^<?:+\\-*/^|&] )$");
Review Comment:
original regex was:
- ether dot
- or slash
- or space at the end of string
new regex matches
- either dot
- or slash
- or space at the end of string. where string does NOT end with operator
(generic type, binary, trinary)
new tests should have explained this...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
