martins-avots commented on PR #1812:
URL: https://github.com/apache/maven-resolver/pull/1812#issuecomment-4137223108
@cstamas Isn't FileLockNamedLock and DefaultTrackingFileManager's basically
the same type of lock aka FileChannel#lock where shared can be set freely?
So instead of `if (lock.lockExclusively(FILE_LOCK_TIMEOUT, SECONDS)) {`
I would do `if (lock.lockShared(FILE_LOCK_TIMEOUT, SECONDS)) {` for
DefaultTrackingFileManager's `public Properties read(Path path) {`?
For `public Properties update(Path path, Map<String, String> updates) {`
and `public Properties update(Path path, Map<String, String> updates) {`
lockExclusively should still be the correct lock?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
