elharo commented on code in PR #1597:
URL:
https://github.com/apache/maven-dependency-plugin/pull/1597#discussion_r3009244924
##########
src/test/java/org/apache/maven/plugins/dependency/exclusion/AnalyzeExclusionsMojoTest.java:
##########
@@ -197,6 +197,29 @@ void testThatLogContainProjectName(AnalyzeExclusionsMojo
mojo) throws Exception
verify(testLog).warn("projectName defines following unnecessary
excludes");
}
+ /**
+ * Nullability behavior of {@link MavenProject#getDependencyManagement} is
not documented, test mojo with both {@code null}
+ * and non-{@code null} outputs
+ *
+ * @see <a
href="https://github.com/apache/maven-dependency-plugin/issues/1474";>Issue</a>
+ */
+ @ParameterizedTest
Review Comment:
This feels overcomplicated for two cases and is really hard to follow. Can
we just have two explicit test methjods, one for each case, no parameterization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
