harrisric commented on PR #700: URL: https://github.com/apache/maven-pmd-plugin/pull/700#issuecomment-4334648963
@slawekjaranowski happy to do that, could you suggest where this would fit in the existing tests? As I noted above this doesn't change the output of the analysis / report in any way. I could write a unit test which shows that the `numThreadsConverter` method works, particularly by separating it from the mojo (and possibly needing to further abstract away the use of `Runtime.getRuntime().availableProcessors()`). Or I could write a test which shows that the value is propagated to the `PMDConfiguration` on the executor, but there are no existing tests like this. Or I could write a further integration-test, though it would likely be a simple copy of an existing test with the new configuration. Also the variations using a multiple of the cores available are not really testable in this sense as we cannot control the cores available in the test environment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
