hboutemy commented on code in PR #816:
URL: 
https://github.com/apache/maven-shade-plugin/pull/816#discussion_r3369191495


##########
.github/workflows/maven-verify.yml:
##########
@@ -24,4 +24,6 @@ jobs:
   build:
     name: Verify
     uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v4
+    with:
+      maven4-enabled: true

Review Comment:
   it seems we're not yet ready for that part: GHA with 4.0-RC5 reports
   
   ```
   [INFO] -------------------------------------------------
   [INFO] Build Summary:
   [INFO]   Passed: 81, Failed: 2, Errors: 0, Skipped: 1
   [INFO] -------------------------------------------------
   Error:  The following builds failed:
   Error:  *  MSHADE-467_parallel-dependency-reduced-pom/pom.xml
   Error:  *  dep-reduced-pom-exclusions/pom.xml
   [INFO] -------------------------------------------------
   ```
   
   just drop that part, we'll rebase #810 and see the much improved situation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to