Copilot commented on code in PR #569:
URL: https://github.com/apache/maven-parent/pull/569#discussion_r3450625005
##########
pom.xml:
##########
@@ -1282,6 +1282,11 @@ under the License.</licenseText>
<exclude>dependency-reduced-pom.xml</exclude>
<!-- GitHub Support -->
<exclude>.asf.yaml</exclude>
+ <!-- Developer tooling: version managers / direnv (local, not
project source) -->
+ <exclude>.sdkmanrc</exclude>
+ <exclude>.tool-versions</exclude>
+ <exclude>.envrc</exclude>
+ <exclude>.mise.toml</exclude>
Review Comment:
RAT exclude patterns are typically ANT-style and are matched relative to the
project base directory; using bare filenames often only excludes files at the
root. If the intent is to ignore these dotfiles anywhere in a multi-module
checkout (e.g., inside submodules), consider switching these to `**/.sdkmanrc`,
`**/.tool-versions`, `**/.envrc`, and `**/.mise.toml`. If you explicitly only
want to exclude root-level files, it would help to clarify that intent in the
comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
