ascheman commented on code in PR #569:
URL: https://github.com/apache/maven-parent/pull/569#discussion_r3462070027
##########
pom.xml:
##########
@@ -1282,6 +1282,11 @@ under the License.</licenseText>
<exclude>dependency-reduced-pom.xml</exclude>
<!-- GitHub Support -->
<exclude>.asf.yaml</exclude>
+ <!-- Developer tooling: version managers / direnv (local, not
project source) -->
+ <exclude>.sdkmanrc</exclude>
+ <exclude>.tool-versions</exclude>
+ <exclude>.envrc</exclude>
+ <exclude>.mise.toml</exclude>
Review Comment:
Thanks for the catch. The surrounding excludes in this file (lines
1280-1284: `.maven/spy.log`, `dependency-reduced-pom.xml`, `.asf.yaml`) all use
bare filenames, and `apache-rat-plugin` runs per-module with the inherited
`<excludes>` applied against each module's basedir — so a `.sdkmanrc` in a
submodule would still be matched by the bare pattern at that submodule's
rat-check execution.
To stay consistent with the surrounding excludes, leaving as bare. Happy to
switch all of them (existing + new) to `**/...` in a follow-up if maintainers
prefer the more defensive form everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
