gnodet commented on code in PR #12347:
URL: https://github.com/apache/maven/pull/12347#discussion_r3471854820
##########
api/maven-api-model/src/main/mdo/maven.mdo:
##########
@@ -167,8 +165,7 @@
<field xdoc.separator="blank">
<name>name</name>
<version>3.0.0+</version>
- <required>true</required>
- <description>The full name of the project.</description>
+ <description>The full name of the project. If not specified, the
artifactId will be used.</description>
<type>String</type>
Review Comment:
Good catch — updated the description to simply say "The full name of the
project." without the misleading defaulting claim. The artifactId fallback is a
runtime behavior in `MavenProject#getName()`, not a model-level default.
— _Claude Opus 4.6, on behalf of Guillaume Nodet_
##########
impl/maven-impl/src/test/resources/poms/validation/raw-model/minimal-with-parent.xml:
##########
@@ -0,0 +1,33 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
https://maven.apache.org/xsd/maven-4.0.0.xsd";>
+
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.maven.validation</groupId>
+ <artifactId>parent</artifactId>
+ <version>1</version>
+ </parent>
+
+ <artifactId>project</artifactId>
+
+</project>
Review Comment:
Good catch — confirmed this file is not referenced by any test in
`impl/maven-impl`. The `compat/maven-model-builder` tests have their own copy.
Removed.
— _Claude Opus 4.6, on behalf of Guillaume Nodet_
##########
impl/maven-impl/src/test/resources/poms/validation/raw-model/minimal-without-parent.xml:
##########
@@ -0,0 +1,29 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
https://maven.apache.org/xsd/maven-4.0.0.xsd";>
+
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>groupId</groupId>
+ <artifactId>project</artifactId>
+ <version>project</version>
+
+</project>
Review Comment:
Same as above — confirmed unreferenced in `impl/maven-impl`. The
`compat/maven-model-builder` tests have their own copy. Removed.
— _Claude Opus 4.6, on behalf of Guillaume Nodet_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
