sparsick commented on code in PR #407:
URL:
https://github.com/apache/maven-shared-utils/pull/407#discussion_r3511331071
##########
src/main/java/org/apache/maven/shared/utils/Os.java:
##########
@@ -365,7 +365,7 @@ private static String getOsFamily() {
return fam;
}
}
- return null;
Review Comment:
I didn't find a contract, that ensures this piece of code should not be
null. I'm afraid, that could have side effects in code that uses it.
For example:
```java
if (Os.OS_FAMILY == null) {
}
```
This snippet would have another meaning after our change.
On the other side, the class `Os` is deprecated, so maybe it is okay to take
this risk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
