cstamas commented on code in PR #1978:
URL: https://github.com/apache/maven-resolver/pull/1978#discussion_r3608162069
##########
maven-resolver-transport-url/src/main/java/org/eclipse/aether/transport/url/UrlTransporterConfigurationKeys.java:
##########
@@ -69,4 +69,15 @@ private UrlTransporterConfigurationKeys() {}
public static final String CONFIG_PROP_REDIRECT_ALLOW_DOWNGRADE =
CONFIG_PROPS_PREFIX + "redirectAllowDowngrade";
public static final boolean DEFAULT_REDIRECT_ALLOW_DOWNGRADE = false;
+
+ /**
+ * Whether persistent connections should be used by this transport. This
configuration allows controlling only this transport,
+ * while the default value (that is JVM-wide) comes from {@code
http.keepAlive} Java system property, that is {@code true}
+ * by default.
+ *
+ * @configurationSource {@link
RepositorySystemSession#getConfigProperties()}
+ * @configurationType {@link java.lang.Boolean}
+ * @configurationRepoIdSuffix Yes
+ */
+ public static final String CONFIG_PROP_KEEP_ALIVE = CONFIG_PROPS_PREFIX +
"keepAlive";
Review Comment:
I would argue about this. I saw all kind of broken MRMs in my life, but this
was still an option to users, as we really do not check what kind of HTTP
headers are they configuring, so they can easily add this header as well.
IMO, the fact this config would exist, would not mean no issue, and even may
be handy in some cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
