desruisseaux commented on code in PR #1076:
URL:
https://github.com/apache/maven-compiler-plugin/pull/1076#discussion_r3614993966
##########
src/main/java/org/apache/maven/plugin/compiler/IncrementalBuild.java:
##########
@@ -774,11 +774,14 @@ List<SourceFile> getModifiedSources() {
/**
* {@return whether the given list of modified files should not cause a
recompilation}
* This method returns {@code true} if the given list is empty or contains
only files
- * with the {@link SourceFile#ignoreModification} set to {@code true}.
+ * with the {@link SourceFile#ignoreModification} set to {@code true}, or
empty source
Review Comment:
It is a small detail, but I suggest to move "or empty source" on the next
line. We try, when reasonable, to change lines at some natural sentence
boundary (after a coma, or after sentence end, _etc_). In case of future
changes, one sentence per line makes clearer in the `diff` which sentence
changed (otherwise a change in one sentence appears as if 2 or 3 sentences were
modified).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
