desruisseaux commented on code in PR #1086:
URL:
https://github.com/apache/maven-compiler-plugin/pull/1086#discussion_r3616041534
##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -649,6 +649,16 @@ final Charset charset() {
* then the default value is same as above with the addition of {@code
"rebuild-on-add,rebuild-on-change"}.
* It means that a full rebuild will be done if any kind of change is
detected.</p>
*
+ * <p>Whether an annotation processor is considered present depends on the
Java version when {@link #proc}
Review Comment:
This is a minor detail, but when reasonable I like to keep each sentence, or
part of a sentence delimited by coma, per line. In this case, it would move
_"is unset,"_ on the previous line. The intent is to make clearer `diff` if we
modify the text in the future. When new lines happen at random locations, a
change in one sentence appears as if 2 or 3 sentences where potentially
impacted. When new lines happen at natural boundaries, `diff` shows only the
sentences (or sentence parts delimited by coma) that were really modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
