elharo commented on code in PR #309:
URL:
https://github.com/apache/maven-source-plugin/pull/309#discussion_r3622053319
##########
pom.xml:
##########
@@ -229,6 +229,7 @@ under the License.
<goal>install</goal>
</goals>
<addTestClassPath>true</addTestClassPath>
+ <mavenOpts>-Dmaven.resolver.transport=wagon</mavenOpts>
Review Comment:
This change is necessary to make the existing tests pass because they use
file:// URLs the default transport doesn't support. Perhaps file an issue to
fix those tests. However, in the meantime I think it is absolutely essential to
get the tests passing. No progress on anything can be made until we do that,
and this is the minimal and safest change I could contrive that accomplishes
that. Once the CI is green, we can carefully move forward with other fixes
without fear of accidentally breaking more things.
The alternative would be to roll everything back to the last known good
commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
