Copilot commented on code in PR #565:
URL: https://github.com/apache/maven-jar-plugin/pull/565#discussion_r3632806180
##########
src/site/apt/examples/create-test-jar.apt.vm:
##########
@@ -85,20 +85,20 @@ How to create a jar containing test classes
</project>
+-----------------+
- Based on such configuration there will be two jar files generated. The first
one contains the
- classes from <<<src/main/java>>> whereas the second one will contain the
classes from <<<src/test/java>>>.
+ Based on such configuration, two jar files wll be generated. The first one
contains the
+ classes from <<<src/main/java>>>. The second one will contain the classes
from <<<src/test/java>>>.
Review Comment:
There is a typo in this sentence ("wll"), and the line ends with trailing
whitespace. This also makes the paragraph read a bit awkwardly across the line
break.
##########
src/site/apt/usage.apt.vm:
##########
@@ -31,16 +31,14 @@
Usage
- Some brief examples on how to use this plugin. If you want to use advanced
- configurations you should have a look at the
+ Some brief examples of how to use this plugin. If you want to use advanced
+ configurations, you should have a look at the
{{{./index.html#Examples}Example section}}.
Review Comment:
This line ends with trailing whitespace (after "the"), which can introduce
noisy diffs and may violate whitespace checks.
##########
src/site/apt/usage.apt.vm:
##########
@@ -31,16 +31,14 @@
Usage
- Some brief examples on how to use this plugin. If you want to use advanced
- configurations you should have a look at the
+ Some brief examples of how to use this plugin. If you want to use advanced
+ configurations, you should have a look at the
{{{./index.html#Examples}Example section}}.
- documentation for
- {{{/shared/maven-archiver/}Maven Archiver}}.
- To handle archiving this version of Maven JAR Plugin uses
+ To handle archiving, this version of the Maven JAR Plugin uses
{{{/shared/maven-archiver/index.html}Maven Archiver}}
${mavenArchiverVersion}.
- <<Note:>> If you need to sign your JAR files you should use the
+ <<Note:>> If you need to sign your JAR files, you should use the
Review Comment:
This line ends with trailing whitespace (after "the"), which can introduce
noisy diffs and may violate whitespace checks.
##########
src/site/apt/usage.apt.vm:
##########
@@ -31,16 +31,14 @@
Usage
- Some brief examples on how to use this plugin. If you want to use advanced
- configurations you should have a look at the
+ Some brief examples of how to use this plugin. If you want to use advanced
+ configurations, you should have a look at the
{{{./index.html#Examples}Example section}}.
- documentation for
- {{{/shared/maven-archiver/}Maven Archiver}}.
- To handle archiving this version of Maven JAR Plugin uses
+ To handle archiving, this version of the Maven JAR Plugin uses
Review Comment:
This PR is titled "Fix typos", but this edit also removes the explicit
pointer to the Maven Archiver documentation that previously followed the
"Example section" link. If that removal wasn’t intentional, consider restoring
it (or otherwise updating the PR title/scope to reflect a content change, not
just typo fixes).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
