ascheman commented on code in PR #1287: URL: https://github.com/apache/maven-site-plugin/pull/1287#discussion_r3636530696
########## src/it/projects/gh-1286-missing-skin/verify.groovy: ########## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +File buildLog = new File( basedir, 'build.log' ) +assert buildLog.exists() + +String log = buildLog.text + +// The build must fail with a clear, actionable message ... +assert log.contains( 'No skin is declared in the site descriptor' ) + +// ... and NOT with the previous cryptic NullPointerException. +assert !log.contains( 'NullPointerException: skin cannot be null' ) Review Comment: Loosened in ac1f66fb to `!log.contains('skin cannot be null')` — that's the exact doxia-sitetools guard message, independent of the exception-type/logging formatting around it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
