ascheman commented on PR #772: URL: https://github.com/apache/maven-shade-plugin/pull/772#issuecomment-5077697839
Tagged `breaking` because this changes the shaded output for existing configurations, not just adds a capability: Previously the `artifactSet` `<includes>`/`<excludes>` only filtered the **main** artifacts — the `sources`, `tests`, and `test-sources` classifier artifacts were shaded **unconditionally**. This change applies the same include/exclude selection to those classifier artifacts too. **Impact:** if you combine `<excludes>` (or `<includes>`) with `createSourcesJar`, `shadeTestJar`, or `createTestSourcesJar`, the artifacts you exclude are now also excluded from the shaded sources/test/test-sources uber-jars — where they were previously (inconsistently) included. Builds that relied on the old behavior will get smaller sources/test jars. This makes the classifier artifacts consistent with the main-artifact selection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
