elharo opened a new pull request, #826: URL: https://github.com/apache/maven-shade-plugin/pull/826
Fixes multiple issues across the site documentation: ### index.apt.vm - **Broken link:** `mail-lists.html` → `mailing-lists.html` (the correct generated page name) - **Insecure link:** `http://` → `https://` for maven.apache.org guide link - **Factual error:** 'a single goal' → '2 goals' — the plugin also has a `shade:help` goal (listed in site.xml) - **Awkward phrasing:** Reworded the introductory sentence for clarity ### usage.apt.vm - **Omission:** Added the 3 missing transformers from `org.apache.maven.plugins.shade.resource.properties` to the resource transformers table ### faq.fml - **Grammar:** 'replaces with original' → 'replaces the original' - **Missing word:** 'ways choose' → 'ways to choose' ### includes-excludes.apt.vm - **Incorrect APT escaping:** Fixed `\` → `\/` so the `<excludeDefaults>false</excludeDefaults>` element renders correctly ### class-relocation.apt.vm - **Typo:** `org.codehaud` → `org.codehaus` (two occurrences in the example POM) ### resource-transformers.apt.vm - **Typo:** 'straight forward' → 'straightforward' - **Possessive:** 'Mavens' → 'Maven's' - **Copy-paste error:** Removed spurious 'NOTICE' from GroovyResourceTransformer description - **Insecure link:** `http://` → `https://` for plugin-tools link - **Unclear phrasing:** Reworded the sentence about Class references - **Redundant phrasing:** Simplified 'opt to merge them by appending their content into one file' ### use-shader-other-impl.apt.vm - **Subject-verb agreement:** 'plugin provide' → 'plugin provides' - **Formatting:** Extracted prose from inside the `+-----+` code block so it renders as text, not code - **Title:** 'an other' → 'another' - **Preposition:** 'Dependency to' → 'Dependency for' - **Word choice:** 'in your job' → 'in your build' -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
