Copilot commented on code in PR #12612: URL: https://github.com/apache/maven/pull/12612#discussion_r3675202707
########## impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultTransportTest.java: ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.impl; + +import java.io.IOException; +import java.net.URI; +import java.nio.file.Files; +import java.nio.file.Path; + +import org.eclipse.aether.spi.connector.transport.Transporter; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.io.TempDir; + +import static org.junit.jupiter.api.Assertions.assertDoesNotThrow; +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.mockito.Mockito.mock; + +class DefaultTransportTest { + + @Test + void testPutWithNonExistentFileThrows() { + Transporter transporter = mock(Transporter.class); + DefaultTransport transport = new DefaultTransport(URI.create("http://example.com/test/";), transporter); + Path nonExistentFile = Path.of("/nonexistent/file.txt"); + assertThrows(IllegalArgumentException.class, () -> transport.put(nonExistentFile, URI.create("dest.txt"))); + } + + @Test + void testPutWithExistingFileSucceeds(@TempDir Path tempDir) throws IOException { + Path sourceFile = tempDir.resolve("source.txt"); + Files.writeString(sourceFile, "test content"); + + Transporter transporter = mock(Transporter.class); + DefaultTransport transport = new DefaultTransport(URI.create("http://example.com/test/";), transporter); + URI dest = URI.create("dest.txt"); + assertDoesNotThrow(() -> transport.put(sourceFile, dest)); + } + + @Test + void testPutBytesSucceeds(@TempDir Path tempDir) { + Transporter transporter = mock(Transporter.class); + DefaultTransport transport = new DefaultTransport(URI.create("http://example.com/test/";), transporter); + URI dest = URI.create("dest.txt"); + assertDoesNotThrow(() -> transport.putBytes("test content".getBytes(), dest)); + } Review Comment: The PR description says this test covers the `putBytes()` -> `put()` delegation chain, but the test currently only asserts that no exception is thrown. To actually verify delegation, spy `DefaultTransport` and `verify(transport).put(...)`, or verify the expected `Transporter` interaction that would only happen via `put()`. ########## impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultTransportTest.java: ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.impl; + +import java.io.IOException; +import java.net.URI; +import java.nio.file.Files; +import java.nio.file.Path; + +import org.eclipse.aether.spi.connector.transport.Transporter; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.io.TempDir; + +import static org.junit.jupiter.api.Assertions.assertDoesNotThrow; +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.mockito.Mockito.mock; + +class DefaultTransportTest { + + @Test + void testPutWithNonExistentFileThrows() { + Transporter transporter = mock(Transporter.class); + DefaultTransport transport = new DefaultTransport(URI.create("http://example.com/test/";), transporter); + Path nonExistentFile = Path.of("/nonexistent/file.txt"); + assertThrows(IllegalArgumentException.class, () -> transport.put(nonExistentFile, URI.create("dest.txt"))); + } Review Comment: `Path.of(\"/nonexistent/file.txt\")` is OS-specific and can be flaky (e.g., Windows path semantics, or a rare case where the path exists). Use a `@TempDir Path tempDir` and reference a file within it that you *don’t* create (e.g., `tempDir.resolve(\"missing.txt\")`) to make the test deterministic and cross-platform. ########## impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultTransportTest.java: ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.impl; + +import java.io.IOException; +import java.net.URI; +import java.nio.file.Files; +import java.nio.file.Path; + +import org.eclipse.aether.spi.connector.transport.Transporter; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.io.TempDir; + +import static org.junit.jupiter.api.Assertions.assertDoesNotThrow; +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.mockito.Mockito.mock; + +class DefaultTransportTest { + + @Test + void testPutWithNonExistentFileThrows() { + Transporter transporter = mock(Transporter.class); + DefaultTransport transport = new DefaultTransport(URI.create("http://example.com/test/";), transporter); + Path nonExistentFile = Path.of("/nonexistent/file.txt"); + assertThrows(IllegalArgumentException.class, () -> transport.put(nonExistentFile, URI.create("dest.txt"))); + } + + @Test + void testPutWithExistingFileSucceeds(@TempDir Path tempDir) throws IOException { + Path sourceFile = tempDir.resolve("source.txt"); + Files.writeString(sourceFile, "test content"); + + Transporter transporter = mock(Transporter.class); + DefaultTransport transport = new DefaultTransport(URI.create("http://example.com/test/";), transporter); + URI dest = URI.create("dest.txt"); + assertDoesNotThrow(() -> transport.put(sourceFile, dest)); + } + + @Test + void testPutBytesSucceeds(@TempDir Path tempDir) { Review Comment: `tempDir` is injected but unused in this test. Either remove the `@TempDir` parameter or use it to control where any temporary file(s) are created (if the production code supports that), to keep the test intent clear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
