wilx opened a new pull request, #12620:
URL: https://github.com/apache/maven/pull/12620
This ports the Maven 3 work from #298 to Maven 4 while preserving
compatibility
with rules and plugins that use the legacy `MavenSession` API.
Maven 4 now retains the model problems reported while discovering the
selected
reactor. The native `Session` exposes the retained
`ProblemCollector<ModelProblem>`
and a `hasModelProblems()` convenience method, while the legacy
`MavenSession#hasModelProblems()` and `setModelProblems(boolean)` methods
bridge
to the same session state.
Problems from a speculative multi-module collection attempt are buffered
until
that attempt is selected. If Maven rejects it and falls back to the
explicitly
requested POM, those unrelated problems are not retained in the final
session.
The collector intentionally has the same scope as the Maven 3 change: reactor
discovery, not every later model-building operation during the build.
Binary compatibility is preserved by adding default methods to the native
`Session` and `ProjectsSelector` interfaces and retaining the existing
project
collection entry points.
Fixes #8485.
Verification:
- `mvn -pl impl/maven-core -am
-Dtest=DefaultSessionTest,DefaultGraphBuilderTest
-Dsurefire.failIfNoSpecifiedTests=false test`
- 40 tests, 0 failures, 0 errors
- `mvn -e -B -V -Prun-its clean install`
- all 90 reactor modules passed
- 1,049 Core ITs completed, 0 failures, 0 errors, 43 skipped
- Checkstyle, RAT, Spotless, and Japicmp passed
- After rebasing onto current `master`, `git range-diff` showed no patch
changes
and the focused 40-test suite passed again.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in
other changes.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
Note that commits might be squashed by a maintainer on merge.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [x] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [x] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
