wilx opened a new pull request, #3421:
URL: https://github.com/apache/maven-surefire/pull/3421
## Summary
- sort discovered test classes before applying the seeded random shuffle
- pass Surefire's `runOrderRandomSeed` to JUnit Jupiter as
`junit.jupiter.execution.order.random.seed`
- propagate run-order provider properties consistently in forked and
in-process execution
- preserve an explicitly configured JUnit Jupiter random seed
- add unit and integration coverage for deterministic discovery order and
JUnit seed propagation
## Why
`Collections.shuffle()` is deterministic only when both its input order and
seed are deterministic. Test-class discovery can return classes in a different
order across filesystems and machines, so the same Surefire seed previously
produced different shuffled orders.
JUnit Jupiter also performs its own class and method ordering. Surefire
selected Jupiter's random orderers for `runOrder=random`, but did not pass
`runOrderRandomSeed` to JUnit. Jupiter therefore used an independent seed and
could not reproduce the complete test order from the Surefire seed.
Sorting the discovered classes before shuffling provides a stable input.
Forwarding the same seed through JUnit's configuration parameters makes
Jupiter's random class and method ordering reproducible as well. An explicit
`junit.jupiter.execution.order.random.seed` in Surefire's JUnit configuration
parameters retains precedence.
Fixes #859
## Validation
- `mvn clean install` passed across all 17 reactor modules on JDK 17
- `mvn -Prun-its clean install` passed; `surefire-its` ran 764 tests with no
failures or errors
- focused `RunOrderIT` passed all 11 tests, including JUnit seed propagation
with `forkCount=0` and `forkCount=1`
- focused Surefire API, common, and JUnit Platform provider unit tests passed
- Spotless, Checkstyle, RAT, and `git diff --check` passed
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean install` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean
install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
