slachiewicz opened a new pull request, #303:
URL: https://github.com/apache/maven-gh-actions-shared/pull/303

   The shared config categorises on 22 labels. **Ten of them exist in no 
repository in the org**, and never have:
   
   ```
   major-enhancement   major-rfe   major-bug   rfe   fix
   bugfix   regression   developer   internal   test
   ```
   
   Three whole categories were built from nothing but those, so **"Major 
features and improvements", "Major bug fixes" and "Changes for developers" 
could never appear in a release note**. Removing them leaves a config that 
describes the conventions the project actually has — which matters, because 
this file is where a contributor looks to learn them.
   
   ## Four dead-looking labels are deliberately kept
   
   They are not in `labels.js`, but they are in use, and dropping them would 
quietly take real pull requests out of the changelog:
   
   | label | where | uses |
   |---|---|---|
   | `chore` | `apache/maven` | 9 |
   | `no-changelog` | `maven-build-cache-extension` | 4 |
   | `tests` | `maven-build-cache-extension` | 3 |
   | `feature` | `maven-fluido-skin` | 1 |
   
   Worth migrating onto the canonical labels (`maintenance`, `skip-changelog`, 
`enhancement`) eventually, but that means relabelling issues, not editing this 
file. Left alone here on purpose.
   
   After this change **every label the config references exists somewhere** — 
twelve canonical, four in live use, none phantom.
   
   ## Two additions while the file is open
   
   **`collapse-after: 10` on the dependency category.** Dependency updates are 
roughly 85% of all labelled items in the org; left alone the category buries 
every other section of every release note.
   
   **A `version-resolver`**, deriving the next version from labels that are 
already being applied:
   
   ```yaml
   major: breaking
   minor: enhancement, feature, removed, deprecated
   patch: bug, documentation, maintenance, chore, build, tests, dependencies
   default: patch
   ```
   
   Both keys validated against release-drafter's own `schema.json` at 
**v7.7.0**, which is the version the shared workflow pins.
   
   ## Notes for review
   
   - **`release-drafter.yml` lives only on `main`** — `v4` and `v5` do not 
carry it, so this is deliberately a single-branch change rather than an 
oversight.
   - The phantom entries were never breaking anything: release-drafter silently 
omits a category no pull request matches. The cost was misleading 
documentation, not broken output — so this is a clarity change, and nothing 
about existing drafts should shift except the collapsing of dependency updates.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to