slachiewicz opened a new pull request, #335: URL: https://github.com/apache/maven-gpg-plugin/pull/335
Part of the estate-wide move of the remaining FAQ pages from FML to Markdown, following the pattern in apache/maven-artifact-plugin#231, apache/maven-assembly-plugin#1354 and apache/maven-javadoc-plugin#1358. ### Two commits, deliberately 1. **A pure rename**, `src/site/fml/faq.fml` -> `src/site/markdown/faq.md`, no content change. 2. **The rewrite**, written by hand. Git records a rename plus a rewrite in one commit as a delete and an add, which stops `git log --follow`. **Please merge or rebase rather than squash.** ### This repo turned up a real trap, worth flagging Anchors here are written `<a id="...">`, not `<a name="...">`. This project inherits `maven-plugins` **48**, which resolves **maven-site-plugin 3.21.0**. That version *drops the `name` attribute* from inline HTML anchors while leaving the element behind. The build stays green and every deep link on the page silently stops working. I hit this: `mvn site` exited 0 and all four anchors had vanished. Demonstrated on this exact file: | toolchain | anchors preserved | |---|---| | this project's own (site-plugin 3.21.0) with `<a name>` | **all 4 lost** | | same file, `-Dversion.maven-site-plugin=3.22.0` | preserved | | same file, `<a id>`, this project's own toolchain | **preserved** | `<a id>` works on both versions, needs no POM change, and is the correct HTML5 spelling — `name` on `<a>` has been obsolete for years. `Xhtml5BaseParser` reads `Attribute.ID` first and only falls back to `NAME`. No version bump is proposed here; the `id` form simply sidesteps the issue. ### Anchors preserved `#question1`, `#site-descriptor`, `#no-pinentry` and `#top` all still resolve. Verified by building the site before and after **with this project's own toolchain** and comparing the anchor set the generated `faq.html` actually serves. The `<head>` is byte-identical and every link target is unchanged. `site.xml` needs no edit — both paths render to `faq.html`. ### What is lost FML's `[top]` back-link after each answer. The question renders as an `h3` instead of a definition term. Nothing else. <sub>Drafted with Claude — please verify</sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
