slachiewicz opened a new pull request, #1010:
URL: https://github.com/apache/maven-archetype/pull/1010
Follow-up to the FML → Markdown FAQ conversion, which is already merged
here. Two small
fixes, one of which is a visible-text regression I introduced.
### 1. A visible-text regression — curly quotes
flexmark's smart-punctuation extension rewrites a straight `"` in Markdown
prose as a
typographic quote. FML, being XML, rendered those quotes straight. So the
converted page
shows **“Old Archetype 1.0.x”** where the original showed **"Old Archetype
1.0.x"**.
This is my mistake in the conversion, and the anchor-preservation check
could not see it —
it is a text change, not an anchor change. Writing `"` in the source
restores the
original rendering; this is the convention maven-site-plugin's own converted
pages already
use.
### 2. `<a id>` instead of `<a name>`
**maven-site-plugin 3.21.0 strips the `name=` attribute from an inline HTML
anchor; 3.22.0
keeps it.** On 3.21.0 every anchor on the page is lost silently, on a green
build. This
repo builds with a parent that pulls 3.22.0, so the page is correct as it
stands — but
`<a id>` survives either way, `Xhtml5BaseParser` reads `Attribute.ID` first
and only falls
back to `NAME`, and `name=` on `<a>` is obsolete in HTML5.
Anchors stay on their own line; folding one into the heading text suppresses
the section's
own generated id.
### Verification
Rendered `faq.html` before and after:
- the anchor set is unchanged, and still a **superset** of every anchor the
original FML
page served, so no deep link changes;
- the `<head>` is byte-identical;
- the visible text now matches the FML original **word for word**, curly
quotes included —
it did not before this change;
- the site log reports no `used more than once` anchor warning.
`target/site` was deleted before each build and the page confirmed
regenerated, so this is
not a stale-output pass.
<sub>Drafted with Claude — please verify</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
