goutamadwant opened a new pull request, #12721:
URL: https://github.com/apache/maven/pull/12721
Fixes #10128.
### Summary
Direct CLI goals currently trigger missing-version resolution for every
plugin in the project before Maven resolves the requested goal. Plugin version
compatibility checks load plugin descriptors, which can download versionless
build and managed plugins even when the goal does not use them.
This change:
- skips project-wide plugin version resolution while calculating direct goal
task segments;
- limits project-wide resolution during execution planning to plans that
contain lifecycle phases; and
- resolves a missing version lazily when a project-declared plugin is
actually considered during prefix resolution.
Lifecycle-phase plans continue to resolve missing plugin versions before
lifecycle mapping. Direct goals continue to resolve the selected plugin through
the existing descriptor path.
### Tests
- `mvn -pl impl/maven-core -am
-Dtest=DefaultPluginPrefixResolverTest,DefaultLifecycleExecutionPlanCalculatorTest
-Dsurefire.failIfNoSpecifiedTests=false test`
- `mvn -pl impl/maven-core -am test`
- `mvn verify`
- Built the Maven distribution and ran `help:help` against an isolated
project with versionless `maven-release-plugin` and `maven-javadoc-plugin`
entries in `pluginManagement`. The command succeeds without resolving or
downloading either unused plugin.
- Attempted `mvn -Prun-its install`. Core IT reached 518 tests, with 494
passing and 23 skipped;
`MavenITmng4428FollowHttpRedirectTest.testitHttpsToHttps` failed while
retrieving an artifact through its local HTTPS redirect server under JDK 26.
This test and failure path are unrelated to the changed plugin-resolution code.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in
other changes.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
Note that commits might be squashed by a maintainer on merge.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [x] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
