gnodet commented on PR #12653: URL: https://github.com/apache/maven/pull/12653#issuecomment-5521961625
Closing based on benchmark results: no measurable improvement on either a 4383-module diamond reactor or a 256-module BOM stress project (230 managed deps, 3-6 BOM imports/module). Deltas were within noise on M4 Pro/JDK 21. Will open a new, smaller PR targeting only the two low-risk hot path optimizations: 1. Precomputed `locationsHashCode` for fast inequality checks in `ModelObjectPool.PoolKey` 2. `computeLocations()` optimization: `HashMap.putAll()` + `Map.copyOf()` replacing `Stream.concat().collect()`, with early return when `newlocs` is empty -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
